feat: add type safety for skippable step dependencies#582
Closed
Conversation
|
This was referenced Jan 8, 2026
Contributor
Author
This was referenced Jan 8, 2026
|
View your CI Pipeline Execution ↗ for commit fa989a4
☁️ Nx Cloud last updated this comment at |
This was referenced Jan 9, 2026
14ed89d to
af7d04a
Compare
2b3cca7 to
966c7d1
Compare
af7d04a to
bdabd07
Compare
966c7d1 to
5db1a76
Compare
bdabd07 to
fa989a4
Compare
5db1a76 to
5c307a0
Compare
Contributor
Author
|
Folded into #572 (squashed conditional steps PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add Type Safety for Skippable Step Dependencies
This PR enhances the Flow DSL's type system to properly handle skippable steps. When a step has
whenUnmet: 'skip'orwhenFailed: 'skip', dependent steps now receive that step's output as an optional property in their dependencies object.Key improvements:
StepMetainterface to track both output type and skippability statusStepInputto make dependencies optional when they come from skippable stepsThis change improves type safety by preventing runtime errors when accessing potentially undefined outputs from skipped steps. Developers will now get proper TypeScript errors if they try to access properties on skippable dependencies without first checking for their existence.
Example usage: