refactor: rename condition_pattern to required_input_pattern and condition_not_pattern to forbidden_input_pattern#587
Closed
jumski wants to merge 1 commit into01-09-pgf-3hs.13_unify_flow_compilation_paths_via_flowshapefrom
Conversation
|
This was referenced Jan 9, 2026
Contributor
Author
|
View your CI Pipeline Execution ↗ for commit ff2191e
☁️ Nx Cloud last updated this comment at |
38446ea to
acd3e0e
Compare
919577f to
be73fb9
Compare
acd3e0e to
534994a
Compare
be73fb9 to
cb18eaf
Compare
534994a to
7bbded0
Compare
7bbded0 to
ff2191e
Compare
cb18eaf to
c376d70
Compare
Contributor
Author
|
Folded into #572 (squashed conditional steps PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Rename Condition Pattern Fields for Better Clarity
This PR renames the database fields and function parameters related to step conditions to improve clarity and better reflect their purpose:
condition_patterntorequired_input_patternto clearly indicate that this pattern must be present in the inputcondition_not_patterntoforbidden_input_patternto clearly indicate that this pattern must not be present in the inputThese changes make the code more self-documenting and align with the semantic meaning of these fields. The renaming is consistent across:
All tests have been updated to use the new field names, and the functionality remains unchanged.