fix: remove bash -c from build:cpp for Windows compat#109
Merged
Conversation
emsdk_env.sh uses BASH_SOURCE which fails silently in dash/sh (default Make shell on Ubuntu), preventing em++ from being found.
timkpaine
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CI failures in generated cpp and cppjswasm template repos:
cpp template (python-template-cpp):
hatch-cpp0.3.0 addedpkndependency →ccflow→pandas→pyarrow, which fails to build from source inside manylinux containers during cibuildwheelhatch-cpp<0.3in bothbuild-system.requiresand develop extrascppjswasm template (python-template-cppjswasm):
bash -c '...'in npmbuild:cppscript fails on Windows ("The system cannot find the path specified")bash -cwrapper with cross-platformnode -efor mkdir and bareem++commandhatch-cpp<0.3to prevent the same manylinux issue