Skip to content

fix: remove bash -c from build:cpp for Windows compat #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timkpaine merged 3 commits into from
Feb 15, 2026
+6 −5
Merged

fix: remove bash -c from build:cpp for Windows compat #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbb7996
fix: pin hatch-cpp<0.3, remove bash -c from build:cpp for Windows compat
timkpaine Feb 14, 2026
a82cb3f
fix: use direct PATH manipulation instead of sourcing emsdk_env.sh
timkpaine Feb 14, 2026
6b5f645
Small fix for cpp to use newer manylinux image
timkpaine Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/pyproject.toml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ test-command = "echo 'TODO'"
test-extras = "develop"

[tool.cibuildwheel.linux]
manylinux-x86_64-image = "manylinux_2_28"
skip = "*i686 musllinux*"

[tool.cibuildwheel.macos]
Expand Down
4 changes: 2 additions & 2 deletions cppjswasm/Makefile.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#########
# BUILD #
#########
EMSDK_ENV := $(shell pwd)/emsdk/emsdk_env.sh
ACTIVATE_EMSDK := if [ -f "$(EMSDK_ENV)" ]; then . "$(EMSDK_ENV)" 2>/dev/null; fi
EMSDK_DIR := $(shell pwd)/emsdk
ACTIVATE_EMSDK := if [ -d "$(EMSDK_DIR)/upstream/emscripten" ]; then export PATH="$(EMSDK_DIR):$(EMSDK_DIR)/upstream/emscripten:$$PATH"; fi

.PHONY: develop-py develop-js develop-cpp develop
develop-py:
Expand Down
2 changes: 1 addition & 1 deletion cppjswasm/js/package.json.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"access": "public"
},
"scripts": {
"build:cpp": "bash -c 'if [ -f ../emsdk/emsdk_env.sh ]; then source ../emsdk/emsdk_env.sh 2>/dev/null; fi && mkdir -p dist/pkg && em++ -O2 -std=c++17 -s WASM=1 -s MODULARIZE=1 -s EXPORT_ES6=1 -s SINGLE_FILE=1 -s ALLOW_MEMORY_GROWTH=1 -s ENVIRONMENT=web,worker --bind -I ../cpp ../cpp/{{project_name_formatted}}/example.cpp src/cpp/bindings.cpp -o dist/pkg/{{module}}.js'",
"build:cpp": "node -e \"require('fs').mkdirSync('dist/pkg',{recursive:true})\" && em++ -O2 -std=c++17 -s WASM=1 -s MODULARIZE=1 -s EXPORT_ES6=1 -s SINGLE_FILE=1 -s ALLOW_MEMORY_GROWTH=1 -s ENVIRONMENT=web,worker --bind -I ../cpp ../cpp/{{project_name_formatted}}/example.cpp src/cpp/bindings.cpp -o dist/pkg/{{module}}.js",
"build:debug": "node build.mjs --debug",
"build:prod": "node build.mjs",
"build": "npm-run-all build:cpp build:prod",
Expand Down
4 changes: 2 additions & 2 deletions cppjswasm/pyproject.toml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[build-system]
requires = [
"hatchling",
"hatch-cpp",
"hatch-cpp<0.3",
"hatch-js",
"pybind11",
]
Expand Down Expand Up @@ -42,7 +42,7 @@ develop = [
"check-manifest",
"cibuildwheel",
"codespell>=2.4,<2.5",
"hatch-cpp",
"hatch-cpp<0.3",
"hatch-js",
"hatchling",
"mdformat>=0.7.22,<1.1",
Expand Down
Loading