Ci #3
Ci #3
Conversation
|
|
|
can you squash it into one commit to avoid having '`ci' in git history? |
.travis.yml
Outdated
| language: python | ||
| sudo: true | ||
| dist: xenial | ||
| git: |
There was a problem hiding this comment.
The depth is not required here
requirements.txt
Outdated
| bblfsh==2.12.7 | ||
| modelforge==0.12.1 | ||
| numpy==1.16.2 | ||
| humanize==0.5.1 |
There was a problem hiding this comment.
humanize is probably included into modelforge
Guillemdb
force-pushed
the
ci
branch
2 times, most recently
from
8a376c0 to
bb6cb1c
Compare
vmarkovtsev
left a comment
vmarkovtsev
left a comment
There was a problem hiding this comment.
LGTM. What's left here:
- Rebase
- Pass the CI
|
@vmarkovtsev As there is no code yet the CI won't pass. I can choose to screw up the CI files to make the CI checks pass, or I can wait for the next PR to include the code. And If I merge the code from the refactor branch here, the tests will fail because they need fixing. Should I also add a commit witht the tests fixing? (I am asking this because you told me to make no changes to the code functionality) |
|
you can add |
Signed-off-by: Guillem Duran <guillem@sourced.tech>
Signed-off-by: Guillem Duran <guillem@sourced.tech>
Signed-off-by: Guillem Duran <guillem@sourced.tech>
Signed-off-by: Guillem Duran <guillem@sourced.tech>
|
@Guillemdb CI is failed. Please request a review when you fix it. |
|
@zurk I have no idea why the build fails. It is obviously missing some files, but I don't know what are the files that need to be there so the CI passes. PR#4 is working like a charm. Is really necessary that I spend more time trying to fix something that works there, and then rebasing everything? EDIT: |
Signed-off-by: Guillem Duran <guillem@sourced.tech>
zurk
left a comment
zurk
left a comment
There was a problem hiding this comment.
Is really necessary that I spend more time trying to fix something that works there, and then rebasing everything?
Yes, because we do not merge if CI fails as a rule without exclusion.
I am ok to merge it if you check all that Vadim asks to check (I mention you there)
|
Vadim's feedback is fulfilled so I am merging |
4 participants
Making PR according to @vmarkovtsev suggestions.
I don't know how to test packaging. Can you send me a tutorial or something? I was planning to do it after the first PR was merged.