Refactor #4
Merged
Refactor #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Konst made some changes to pass the tests: Also, the version of modelforge used in the requirements is updated to |
Collaborator
|
@Guillemdb Please rebase this on the latest changes in the other 2 PRs |
Guillemdb
force-pushed
the
refactor
branch
5 times, most recently
from
cf13b34 to
6d82e5e
Compare
Contributor
|
ok, I updated comment that PR is based on #3. |
Merged
Contributor
|
@Guillemdb please rebase and solve the conflict |
added 5 commits
April 26, 2019 18:45
Signed-off-by: Guillem Duran <guillem@sourced.tech>
Signed-off-by: Guillem Duran <guillem@sourced.tech>
Signed-off-by: Guillem Duran <guillem@sourced.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is based on #3
This PR will contain the changes suggested by @vmarkovtsev in #1